Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Chemist profession #77915

Closed
wants to merge 2 commits into from
Closed

Adds Chemist profession #77915

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2024

Summary

Content "Adds Chemist as a profession"

Purpose of change

  • CDDA has an extensive chemical crafting system, and a skill that is (mostly) based on Chemistry. It only makes sense to allow players to play as chemists if they wish.

Describe the solution

  • Adds a Chemist profession that allows players to focus on (and roleplay around) the extensive chemistry mechanics of the game if they wish.

Describe alternatives you've considered

  • None

Testing

  • Tested on experimental 11-15-0512.

Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies new contributor astyled astyled PR, label is assigned by github actions labels Nov 16, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 16, 2024
@GuardianDll
Copy link
Member

Was #76494 issues adressed?

@ghost
Copy link
Author

ghost commented Nov 16, 2024

Was #76494 issues adressed?

Indeed, you may check the last comment and subsequent PR.

@kevingranade
Copy link
Member

Completely redundant with chemical engineer.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants