Fix has_ammo and has_ammo_info #77887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #77845, i.e. firing gun grenade launcher from gun with full mag crashes.
This was caused by #77624.
Describe the solution
Fix the implementation of has_ammo and has_ammo info to NOT lie when there's an empty magazine.
Also minor efficiency change by only getting ammo_data once.
Describe alternatives you've considered
Testing
Running the scenario from the bug report. Damaged PC significantly by firing at too short a distance the first time, and got an explosion a fair bit off target on the second run of the save.
Additional context