Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nunez bullet trailer appearing out of nowhere #77879

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Nov 15, 2024

Summary

Bugfixes "Fix nunez bullet trailer appearing out of nowhere"

Purpose of change

Fixes #77877

Describe the solution

Obsoletes the old EoC that was stored in memory bc it was recurrance
Renames the new EoC
Fixes bullet trailer rotating
Adds a roof to the bullet trailer
Stops the bullet trailer spawning in the fence for two ranch_camp_55 rotations

Describe alternatives you've considered

Changing the cursed palette of the trailer proper

Testing

Simplified the EoC to test it on all rotations

  {
    "id": "EOC_Nunez_Travel_To_Tacoma",
    "type": "effect_on_condition",
    "effect": [
      {
        "mapgen_update": "tacoma_nunez_trailer_arrive",
        "om_terrain": "ranch_camp_55"
      }
    ]
  },

resulting in
image
image

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 15, 2024
@Maleclypse Maleclypse merged commit 0461e7d into CleverRaven:master Nov 17, 2024
20 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nunez weirdo vehicle teleports in on dirt floor construction
2 participants