faraday CBM now protects your bionic power

[Kamejeir]

Summary

None

Purpose of change

Tightly woven faraday cages should protect against any waves smaller than the earths magnetic field.

I interpret bio_faraday as though it's creating a pseudo-faraday cage, because my biggest issue is electric fields draining your power despite apparently protecting against shocks.

The RM13 and Phase Immersion Suit are changed because:

• RM13 is explicitly only ELECTRIC_IMMUNE when powered, so I figure whatever is going on, it's probably actively deflecting incoming disturbances.
• Phase Immersion Suit is both (whatever I said above) as well as being designed for very hostile environments. Maybe even something close to solar flares.

Describe the solution

Right now I've dragged together everything I've found that is either a faraday cage or what presumably uses some sort of powered EMP neutralization. Not merely any big blanket or bodyglove made of nomex.

This being in draft: I only intend to prevent bionic power being drained. The current edits seemingly making your smartphone in your backpack immune to being fried is unintended.

Add another flag, apply it to bio_faraday, make the bionic power drain check for it.

Describe alternatives you've considered

Testing

With an active bio_faraday, I don't lose power, but my items still break.

Additional context

[Kamejeir]

Discussion has pointed me to a previous discussion of different devs (discord link) revealed that EMP-proof properties don't really apply for faraday cages that are not electrically connected to the items they are trying to protect. This liberates me from worrying about implementing special pocket properties (but still need to make sure magic mods can have all the EMP_IMMUNE flags they like). The suits currently being edited still have all necessary bits for the desired effect, except the very important part where it needs to form a strong ground, as it would likely only be via your feet touching the ground.

The purpose of the PR, preventing bionic power storage being sapped of its energy even while things such as the suits and bio_faraday are in effect and you not even being zapped is, as a result, in an uncertain state and I need to think about it.

[Kamejeir]

If I were to finish this up and leave it for the merger to decide, I would probably:

• Make another flag for specifically emp-immunity when it comes to protecting your items and apply at

Cataclysm-DDA/src/explosion.cpp

Lines 817 to 824 in 65b3721

	for( item_location &it : player_character.all_items_loc() ) {
	// Render any electronic stuff in player's possession non-functional
	if( it->has_flag( flag_ELECTRONIC ) && !it->is_broken() &&
	get_option<bool>( "EMP_DISABLE_ELECTRONICS" ) &&
	!player_character.has_flag( json_flag_EMP_IMMUNE ) ) {
	add_msg( m_bad, _( "The EMP blast fries your %s!" ), it->tname() );
	it->deactivate();
	it->faults.insert( faults::random_of_type( "shorted" ) );

• Edit back the description of faraday CBM to avoid confusion

But just wait for a bit in case anyone else has anything to say.

• The special military gear and HEV suit would not be designed to protect whatever is inside it, and certainly does not have a solid electrical connection to your internal power banks. Iffy.
• I am still holding out hope for faraday CBM actually being designed to protect your power supply, even if weird alien tech isn't anything you can really make involved arguments about.