Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "abstractify basic walls"
Purpose of change
Colored wall bloat is egregious, as is redefining the same flags over and over
Describe the solution
Set up a simple wall hierarchy by material
Also, defined values for fields in map_common_bash_info and related structs' constructors.
copy-from
uses the default constructor, and unset fields default to values inconsistent with the defaultoptional
values from load() functions, so copying from an abstract terrain didn't work.I didn't do half-walls here because they have differences that seemed questionable
Describe alternatives you've considered
Testing
Additional context
Let me know if I misplaced anything. I'd like to do this with windows, but they need extra work for
copy-from