Improve f_consume_item_sum and f_has_items_sum, use it more #77791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
github-actions
bot
added
BasicBuildPassed
db48x
reviewed
Nov 18, 2024
|
|
||
| percent += count_present / amount_desired; | ||
|
|
||
| if( percent <= 1.0 ) { |
There was a problem hiding this comment.
I’m not one to complain, but why don’t you just compare count_present >= amount_desired?
db48x
reviewed
Nov 18, 2024
|
|
||
| while( percent < 1.0 ) { | ||
| percent += ratio / count_present; | ||
| ++amount_to_remove; |
There was a problem hiding this comment.
And here you could just set amount_to_remove = amount_desired.
There was a problem hiding this comment.
Because if you have desired item A be 10, and desired item B to be 10, and happen to have item A of 5 and item B of 7, instead of consuming item A of 5 and item B of 5, the code would instead consume item A of 5 and item B of 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Finally fix #74451
Describe the solution
better code, smarter code, now it works in PICKUP_RANGE
use it in two quests that i was asked to
Testing
Running it as eoc works correctly, see no reason it should not work in quests