Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestions requested ] Portuguese for Portugal is still missing in options. Attempts to fix #77775

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

Maleclypse
Copy link
Member

Summary

I18N "Make Portugal Portugues appear in Options"

Purpose of change

Get new language to show up in options

Describe the solution

I've attempted to match the naming schema to match the po file. I've also split out brasilian and portugul into their different microsoft language codes. Mirrors #24832 However all I'm accomplishing when I compile is removing every language but english from the language options.

Describe alternatives you've considered

Making better decisions with my life.

Testing

Additional context

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` Translation I18n astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 12, 2024
src/lang_stats.inc Outdated Show resolved Hide resolved
src/options.cpp Outdated Show resolved Hide resolved
src/lang_stats.inc Outdated Show resolved Hide resolved
src/options.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 12, 2024
@themaster567
Copy link
Contributor

themaster567 commented Nov 13, 2024

I believe that there needs to be a MOTD and credits file or there's a chance that most of the title screen and the entire credits screen will be blank. I propose that the PT_BR one for each is copied and pasted as a placeholder until they can be properly translated.

@Maleclypse
Copy link
Member Author

I believe that there needs to be a MOTD and credits file or there's a chance that most of the title screen and the entire credits screen will be blank. I propose that the PT_BR one for each is copied and pasted as a placeholder until they can be properly translated.

Don't those default to English when not translated?

@themaster567
Copy link
Contributor

Possibly, but every other language shipped with the game has a MOTD file, so I haven't personally seen that.

@Maleclypse
Copy link
Member Author

@katemonster33 I think I've figured out that there is something missing in regards to AddGlyphRangesFromCLDRForPT and that's causing the new portuguese dialect to not show up in the language selection and me using that line twice is probably the reason that when I compile this all languages except english are missing? I'm just not sure what to do here since I can't really copy any other language additions as this is the first since this menu migrated to imgui. When you have a second can you look at this? Thanks!

@mqrause
Copy link
Contributor

mqrause commented Nov 13, 2024

This PR works for me. If all languages are missing for you, then that means the po files weren't created. There's an extra script you need to run for this when you compile with VS.

@Night-Pryanik Night-Pryanik merged commit 918bc6f into CleverRaven:master Nov 13, 2024
20 of 26 checks passed
@Maleclypse Maleclypse deleted the Fix-Portuguese- branch November 14, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants