Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete unused generic NPC classes #77772

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Obsolete unused generic NPC classes #77772

merged 1 commit into from
Nov 16, 2024

Conversation

ShnitzelX2
Copy link
Contributor

Summary

Infrastructure "obsolete unused generic NPC classes"

Purpose of change

Cleanup from #76935

image

Describe the solution

Put unused JSON objects from #76935 into new file in obsolete folder. This is, specifically: NC_ARMY, NC_HACKER, NC_MOTORHEAD, NC_NINJA, NC_OPS, NC_SCIENTIST, and NC_TRADER.json, along with their npc_class definitions. The rest of the classes listed in #76935 were still used by unique NPCs.

Removes any hardcoded checks to the above NPC classes.

Describe alternatives you've considered

Testing

Game loads, local tests pass

Additional context

May do more work on random NPCs in the near future

@github-actions github-actions bot added Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Missions Quests and missions [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 12, 2024
@ShnitzelX2 ShnitzelX2 force-pushed the remove-obsolete-npc-class branch from e2e7364 to beba234 Compare November 12, 2024 21:01
@Maleclypse Maleclypse merged commit ca3a273 into CleverRaven:master Nov 16, 2024
21 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShnitzelX2 @Maleclypse