Lower single point sling min_item_volume to hold atlatl spear

[ampersand55]

Summary

None "Lower single point sling min_item_volume to hold atlatl spear"

Purpose of change

EDIT: I just noticed that the error is because the recipe makes two atlatl spears which has a higher volume. Had I known this I would probably have made a bug report instead. I've re-worded the PR to reflect this.

But as I think the single point sling would be able to store items the same way as a rope, a vine or a seatbelt, I'll keep this PR open as a draft.

---

The single point sling pocket has a min_item_volume of 1 L. A single atlatl spear has a volume of 0.58 L. In the crafting menu it says a single point sling can store atlatl spearce since the recipe makes two and two atlatl spears have more than the required minimum volume.

Cataclysm-DDA/data/json/items/armor/holster.json

Lines 196 to 205 in 6e7f4ff

	"pocket_data": [
	{
	"pocket_type": "CONTAINER",
	"holster": true,
	"min_item_volume": "1000 ml",
	"max_contains_volume": "8 L",
	"max_contains_weight": "8200 g",
	"max_item_length": "120 cm",
	"moves": 30
	}

Describe the solution

Lower the single point sling min_item_volume to 0.5 L.

This actually makes the atlatl a viable weapon for a standard survivor/evac shelter start.

Describe alternatives you've considered

In real life, you would probably also need something to tie the atlatl spears to the sling. But in this respect, a singlepoint sling would probably function just as well as a vine, rope or seatbelt.

Someone else should probably look at the c++ "Can be stored in" logic.

Testing

Works in game as expected.

Additional context

[kevingranade]

A single point sling is not going to work the same as a vine or something because it doesn't have a nice flexible cord to tie, it has some kind of carabiner or snap on the end that you attach to a specific point on your gun, no snap point, no holding.

This is also intrinsic to how the thing works, as it allows you to attach/detach rapidly and even use the item while attached, none of which is the case for a spear, so the resulting performance is not correct.

Craft the thing into an equivalent to a tied rope or vine? Yea maybe, then it can get an appropriate move cost assigned instead of the very fast one the sling has.