Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.H] Migrate railroad station OMTs and cancel said migration in railroads mod #77695

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Nov 9, 2024

Summary

None

Purpose of change

Railroad station OMTs weren't migrated

Describe the solution

Normal migration doesn't cut it bc the OMTs still exist in the railroads mod so I've added infra to overwrite and cancel migrations for mods

Describe alternatives you've considered

Marking the railroads mod as WIP in its name or just obsoleting it in 0.H bc it's not really intended to be used in a normal playthrough (it borks road gen heavily and you can't drive over level crossings)

Testing

Started an 0.G save with ramped up station spawns (just removed "UNIQUE"). Loaded said save in 0.H and got expected migration. Started an 0.H save with the railroads mod and ramped up station spawns, saved and loaded it a few times with expected results.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Info / User Interface Game - player communication, menus, etc. labels Nov 9, 2024
@Procyonae Procyonae changed the title Migrate railroad OMTs and cancel said migration in railroads mod Migrate railroad station OMTs and cancel said migration in railroads mod Nov 9, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 9, 2024
@Procyonae Procyonae changed the title Migrate railroad station OMTs and cancel said migration in railroads mod [0.H] Migrate railroad station OMTs and cancel said migration in railroads mod Nov 9, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 9, 2024
@Maleclypse Maleclypse merged commit 22690fe into CleverRaven:0.H-branch Nov 10, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants