Make enchantment influence dps shown in item #77687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Item DPS field is a field that already reflect you using this weapon against different enemies; it is influenced by both item properties, and character stats and effects: strength, pain and similar
There is little reason to omit possible enchantments if they are presented
Describe the solution
Add modify_damage_dealt_with_enchantments() to dps calculations in UI
Testing
Default character with skill 5
Default character with skill 5, and 1000 additional bash damage added
Additional context
once #77662 will be merged, someone need to run across all melee enchantments, and if it's an item, replace said enchantment with damage, specified in item definition (unless it utilizes math or similar properties, it would be tricky then)