Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Fix talker errors with a couple lilin spells #77660

Merged

Conversation

Standing-Storm
Copy link
Contributor

Summary

Bugfixes "[Xedra Evolved] Fix talker errors with a couple lilin spells"

Purpose of change

Targeting an area of ground with Unleash the Night-Wind would evoke a talker error because if there were no creature there, there's no alpha talker. However, Procyonæ informed me that this actually doesn't matter--if you just tell the EoC not to run on the target point if there's no creature there, it still runs on everyone else in the AoE.

Also, I found a couple places where it was trying to read the ruach of the target, not the lilit.

Describe the solution

Add has_alpha to the night-wind EoC, so it runs as described above.

Swap some u_ to n_ in various checks to prevent "non-character vitamin" errors.

Describe alternatives you've considered

Testing

No more errors.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Nov 7, 2024
@github-actions github-actions bot requested a review from Maleclypse November 7, 2024 22:29
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 7, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 8, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 8, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 8, 2024
@Night-Pryanik Night-Pryanik merged commit 7166775 into CleverRaven:master Nov 8, 2024
18 of 24 checks passed
@Standing-Storm Standing-Storm deleted the fix-night-wind-talker branch November 8, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants