some eoc improvements #77571
Merged
some eoc improvements #77571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Just a few nitbits i found while looking at eoc
Describe the solution
lab_security_check do not every second/every 15 seconds/every 30 seconds, instead running when you cross overmap border
so does quiet farm
quiet farm eoc was simplified, instead of defining nearly each effect as separate eoc, it simply runs a big-ass eoc and that's it
Testing
I played quiet farm from beginning to end, seems to work fine
Walked in TCL, nothing suspicious found
Additional context