Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shelter and burning building starts #77483

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Oct 31, 2024

Summary

Bugfixes "Fix shelter and burning building starts"

Purpose of change

Fix #77474

Describe the solution

Adds a ZONE_START_POINT entry to each shelter variant
Removes ZONE_START_POINT from Road mapgen file

Describe alternatives you've considered

Reverting all #77451
Making big changes to #77451

Testing

Game loads no errors except an intermittent error on car crash. Sometimes that throws a tripoint mapgen error and lands you in the road outside a vehicle,
Screenshot 2024-10-31 at 4 13 21 PM

sometimes it puts you in a house.
Screenshot 2024-10-31 at 4 17 16 PM

Shelter start works:
Screenshot 2024-10-31 at 4 11 59 PM

Building on fire works:
Screenshot 2024-10-31 at 4 14 27 PM

Additional context

Should reopen #54731 until we can come up with a better fix

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 31, 2024
@LyleSY LyleSY marked this pull request as ready for review October 31, 2024 18:59
@LyleSY LyleSY changed the title Fix shelter spawns Fix shelter and burning building starts Oct 31, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 31, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 1, 2024
@PatrikLundell
Copy link
Contributor

A question: Is "fix all of" picked up by the auto report closing logic, or should it be changed to "fix(ed)" for that to work?

@LyleSY
Copy link
Contributor Author

LyleSY commented Nov 1, 2024

Not sure! I've changed it just in case EDIT: Yes, had to use that language for it to kick in

@Maleclypse Maleclypse merged commit 33f9490 into CleverRaven:master Nov 2, 2024
18 of 25 checks passed
@LyleSY LyleSY deleted the spawn_in_shelter branch November 2, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple scenarios incorrectly make you spawn on a road
3 participants