Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new no-lid variant of large clay pot, make it usable for the slow sand water filter #77463

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

NetSysFire
Copy link
Member

Summary

Content "Large clay pots can now be crafted without a lid and used in the slow sand water filter"

Purpose of change

Did a run. Realized you can't boil murky water to purify now. It needs a filter. But that filter needs a large plastic bucket. And only wants this specific container with no alternatives.

Describe the solution

  1. Adds a new no-lid variety of the large clay pot so you can achieve a water filter without having to hunt and skin animals first. Or find suitable clothing or parts to cut up.
    • Yes, even though the lid is missing the container copies the weight from the one with the lid. The difference should be below 100g. The density checker scares me.
    • Takes 3 minutes less to craft than the variant with a lid.
  2. Bonus bugfix: The normal clay pot is crafted without a lid. As such, it is an open container. This adds the open container property to it.
  3. Adds both large clay pots to the slow sand water filter recipe.
    • The large clay pot is bigger and heavier than the large plastic bucket. I'd need to add a separate item and recipe to accomodate this. I did not for the sake of simplicity. There is no potential to exploit this however.
  4. Clarifies the description of clay containers with lids to specifically point that out.

Describe alternatives you've considered

Other containers. But they need to be big enough. A barrel might work, too and can use a different recipe and filter more water per run. For this I need to do maths though and maths are scary and not to be done at this time of day.

I wonder if we can use smaller containers but require multiple filtration runs, too.

Additionally but this is definitely out of scope for this PR is looking into making this an item that transforms after a set amount of time, like the purifying water. The only issue with this is making sure both the filter and the water gets generated and that the filter does not magically forget its crafting components.

Testing

Applied changes locally and tested crafting it. Disassembly works as expected and does not magically turn a large clay pot into a plastic bucket.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 30, 2024
@NetSysFire
Copy link
Member Author

@nornagon what is your take on using a big barrel for water filtering?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 31, 2024
@Maleclypse Maleclypse merged commit 38a32aa into CleverRaven:master Nov 2, 2024
17 of 24 checks passed
@nornagon
Copy link
Contributor

nornagon commented Nov 2, 2024

@NetSysFire seems fine to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants