less usage of generic rewards: Tacoma #77453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
github-actions
bot
added
astyled
still need to figure out how to reach this point
yet to be playtested
Kamejeir
force-pushed
the
tacoman_rewards-generic_minus_scav
branch
from
3f1e98c to
0a71a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Bootstrapping the Tacoma ranch right now makes all the inhabitants indebted to you for life, but it's not as though that makes perfect sense: They can't just start giving away all their stock to you, because they still report to the Refugee Center to facilitate trading. Besides, most of them don't even have a shop running (the part that bothers me the most, as you get to look at taking their personal belongings when you don't really have any business doing so).
Describe the solution
Set
"has_generic_rewards": falseto most NPCs in Tacoma (exception is Scavenger Boss, because he does have a shop with enough value attached, while giving quests. Reward could feasibly come in the form of wares... you're practically selling gear to him with the quests. I just chose not to touch that because it involves arbitrary adjustment of the "value" value)This being in draft: Setting upAdded more believable rewards with the end of Doctor and Bartender quests (the foreman giving you cash for use in other shops)Describe alternatives you've considered
Testing
When this is out of draft, I'll hopefully have done everything in regards to testing it working and adjusting dialogue options.Did all the quests for the Foreman, Nurse, Doctor and Bartender (I couldn't figure out how to do the Pablo quest, but I will trust that the setting change that breaks for noone else, would not break with him). I mostly looked for the post-quest "How about some items as payment?" and did not see any such prompt for the questlines in question.
Tested the Foreman giving you cash, and I see no dialogue out of place (he only says the "Hello again" thing whenever there's an unclaimed reward)
Additional context
"Can you share some equipment?" on mission start is not something I've figured out how to avoid, but whether I should is something I have not yet pondered. In doing the Scrapper quests (for the Doctor) it seems such extraneous options don't exist, but I'm not perfectly how to achieve that, nevermind it not really being the point of this PR.
look karol, I'm deleting (rewards) by adding lines!