-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default ImGui font to terminus to fix text position issues #77415
Conversation
Another font shuffling? But why? I think we'd rather fix the issues themselves. |
That would indeed be better. As mentioned this is temporary fix to a high-priority issue, not a replacement for a fix to the issue itself. |
I am in favor of reverting the font change to Helvetica as it indeed causes nasty issues. The new font actually looks quite good and readable but this is not worth the issues imo. |
I assume you mean terminus? I agree that Roboto looks better. We could use Roboto Mono, which is basically a monospaced version of Roboto Regular that's also free using the same Apache 2.0 licence. |
We changed from Terminus to Helvetica, the non-monospaced font that is causing issues right now, which you seek to revert so we are back at Terminus. |
What do you mean? The current default gui monospaced font is Roboto-Medium. Cataclysm-DDA/data/fontdata.json Lines 8 to 9 in 0d9cbd1
Here's a comparison between Roboto mono and Terminus using the ImGui menu: Roboto mono: Terminus: |
Nevermind then, I did apparantly mean Roboto. Someone of the team said something about Helvetica and I believed that without checking. |
I would prefer to get #76513 committed. |
Me too, this was only meant as a temporary fix. I'm closing this. |
Summary
Bugfixes "Change default ImGui font to terminus to fix text position issues"
Purpose of change
Temporarily fix #77297 and #77402
Describe the solution
Change default imGui font to terminus, the default font for other UI.
Describe alternatives you've considered
Testing
NOT TESTED
I can't seem to compile on this PC.
I don't see how this one-line change could fail, but someone should probably test this just in case.
Additional context