Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default ImGui font to terminus to fix text position issues #77415

Closed
wants to merge 2 commits into from

Conversation

ampersand55
Copy link
Contributor

@ampersand55 ampersand55 commented Oct 28, 2024

Summary

Bugfixes "Change default ImGui font to terminus to fix text position issues"

Purpose of change

Temporarily fix #77297 and #77402

Describe the solution

Change default imGui font to terminus, the default font for other UI.

Describe alternatives you've considered

Testing

NOT TESTED

I can't seem to compile on this PC.

I don't see how this one-line change could fail, but someone should probably test this just in case.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 28, 2024
@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Oct 28, 2024
@RenechCDDA
Copy link
Member

Another font shuffling? But why? I think we'd rather fix the issues themselves.

@ampersand55
Copy link
Contributor Author

That would indeed be better. As mentioned this is temporary fix to a high-priority issue, not a replacement for a fix to the issue itself.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 29, 2024
@NetSysFire
Copy link
Member

I am in favor of reverting the font change to Helvetica as it indeed causes nasty issues. The new font actually looks quite good and readable but this is not worth the issues imo.

@ampersand55
Copy link
Contributor Author

I assume you mean terminus?

I agree that Roboto looks better. We could use Roboto Mono, which is basically a monospaced version of Roboto Regular that's also free using the same Apache 2.0 licence.

https://fonts.google.com/specimen/Roboto+Mono

@NetSysFire
Copy link
Member

We changed from Terminus to Helvetica, the non-monospaced font that is causing issues right now, which you seek to revert so we are back at Terminus.

@ampersand55
Copy link
Contributor Author

We changed from Terminus to Helvetica, the non-monospaced font that is causing issues right now, which you seek to revert so we are back at Terminus.

What do you mean? The current default gui monospaced font is Roboto-Medium.

"gui_typeface": [
"data/font/Roboto-Medium.ttf",

Here's a comparison between Roboto mono and Terminus using the ImGui menu:

Roboto mono:

image

Terminus:

image

@NetSysFire
Copy link
Member

Nevermind then, I did apparantly mean Roboto. Someone of the team said something about Helvetica and I believed that without checking.

@db48x
Copy link
Contributor

db48x commented Oct 31, 2024

I would prefer to get #76513 committed.

@ampersand55
Copy link
Contributor Author

I would prefer to get #76513 committed.

Me too, this was only meant as a temporary fix. I'm closing this.

@ampersand55 ampersand55 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect text position in menu [ImGUI]
4 participants