-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the game to build on OSX #77413
Conversation
329e47f
to
c1b4bc4
Compare
Doesn't seem to work very nicely for building a universal binary. I don't have much C++ experience, and even less time to get this to work properly. If someone wants to figure out how to get the dynamic library working for both x86_64 and arm64 at the same time, feel free to do so, but I'll close this PR in the meantime. |
plugging these two lines in - allowed me to complete the build, thanks! |
@johannes-graner hi friend, i think your fix here is correct, would you mind reopening this? Regarding the build failures youre talking about with arm64, can you list your error message? |
Hi! Sure, I can reopen the PR, but I don't think. I can finish it. The relevant failure is at this CI step, which only shows up when building a universal binary. I have an arm64 Mac, and I can build fine locally as long as I omit |
Hey, thanks for this fix. We can go ahead and commit this once basic build passes, I have followup fixes that will fix our mac ci builds. |
Summary
Build "Allow the game to build on OSX"
Purpose of change
The game did not compile on OSX, neither locally nor in experimental release GH action, due to the Makefile not linking the
freetype2
library. Closes #77410.Describe the solution
Include and link the library when building for OSX.
Describe alternatives you've considered
Figuring out if there is a reason why this is not included for all tiles builds, regardless of operating system. I'll leave that to someone with more experience of the makefile, and I don't want to break what isn't broken.
Testing
Compiles locally. Removing the
obj/tiles/third-party/imgui
directory and recompiling works fine.Additional context