Throwing items while piloting mechs (with the mech's assist)

[Night-Pryanik]

Summary

Features "Throwing items while piloting mechs (with the mech's assist)"

Purpose of change

Using mech's arms to throw items is plausible and useful feature, especially if we have existing infrastructure for that kind of throwing.

• Closes Can't use throwing weapons while inside mechsuits #53588.

Describe the solution

Added check for being in a mech in avatar_action::plthrow. Bypass check for whether we can wield an item prior to throwing, and don't wield that item at all if we're in a mech.

Describe alternatives you've considered

Remove existing code for mech's assist in throwing range calculations. But that would be terrible in my opinion.

Testing

Got a can of cola in my inventory. Pressed t to open the throwing menu, checked maximum distance I can throw the can (5 tiles). Confirmed throwing, can flew to the target tile, no errors observed.

Got the same can of cola in my inventory. Piloted a lifting mech. Pressed t to open the throwing menu, checked maximum distance I can throw the can (92 tiles). Confirmed throwing, can flew to the target tile, no errors observed.

Additional context

We might need to make some adjustments to throwing accuracy calculations as well, but that can wait, I guess.

[PatrikLundell]

What happens if you try to throw it out of the reality bubble (since the max distance is larger)? For starters, it shouldn't crash the game, and secondly, it ought to land at the destination (i.e. the actual destination after errors are taken into consideration), rather than vanishing from existence.

A work around would be to cut the maximum range down to 60 tiles, to ensure it is within the shortest reality bubble range, but then errors mustn't cause the resulting range to exceed 60.

[Night-Pryanik]

What happens if you try to throw it out of the reality bubble (since the max distance is larger)?

My testing showed that game puts the throwable at the edge of the bubble. E.g. I aimed at max 92 tiles, but all my 10 cans of cola landed at 60 tiles.

For starters, it shouldn't crash the game

It doesn't crash the game.

secondly, it ought to land at the destination (i.e. the actual destination after errors are taken into consideration), rather than vanishing from existence.

It doesn't vanish from existence, it lands at 60 tiles from the mech.