Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Fix EOC_PERK_BURNING_BRIGHT_RAISE_ATTUNEMENT error #77058

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Oct 15, 2024

Summary

Bugfixes "[MoM] Fix EOC_PERK_BURNING_BRIGHT_RAISE_ATTUNEMENT error"

Purpose of change

When I was working on the perks for MoM, the folder was named modinteractions. The PR that allowed mod interactions made it so that files in the mod_interactions folder are ignored unless the associated mod id matching the subfolder is loaded, but modinteractions are processed, so I didn't get any error messages when testing my PR.

Now that the file is under the mod_interactions folder, it doesn't load unless Bombastic Perks is loaded, which means that the game tries to call EOC_PERK_BURNING_BRIGHT_RAISE_ATTUNEMENT every time a power is maintained, when unless you have Bombastic Perks loaded, it doesn't exist.

Describe the solution

Add a dummy version of EOC_PERK_BURNING_BRIGHT_RAISE_ATTUNEMENT that does nothing and is empty. This will require #76983 (which prevents a double-definition error if one of those definitions is in the mod_interactions folder) to be merged before it works.

Describe alternatives you've considered

Testing

Loaded up a game with just MoM and concentrated on some powers, no error messages.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft October 15, 2024 01:02
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 15, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review October 20, 2024 00:29
@Night-Pryanik Night-Pryanik merged commit fc827ed into CleverRaven:master Oct 20, 2024
27 of 33 checks passed
@Standing-Storm Standing-Storm deleted the fix-burning-bright-error branch October 21, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants