Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate origin string generation #77030

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Deduplicate origin string generation #77030

merged 1 commit into from
Oct 18, 2024

Conversation

ehughsbaird
Copy link
Contributor

@ehughsbaird ehughsbaird commented Oct 14, 2024 •
edited
Loading

Summary

Infrastructure "Remove duplicated code to generate origin string"

Purpose of change/Describe the solution

There's a templated function to do this, so use it instead of scattering the same snippet of code around in all the places that do this.
See #76983

Testing

image image image image image

@ehughsbaird
Deduplicate origin string generation
c3ce62c 
There's a templated function to do this, so use it instead of
scattering the same snippet of code around in all the places we want to
do this.
@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Character / World Generation Issues and enhancements concerning stages of creating a character or a world Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 14, 2024
@Night-Pryanik Night-Pryanik merged commit 77e1ead into CleverRaven:master Oct 18, 2024
24 of 29 checks passed
@ehughsbaird ehughsbaird deleted the dont-dupe-code branch October 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Monsters Monsters both friendly and unfriendly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehughsbaird @Night-Pryanik