Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix game not compiling on GCC #77017

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

Faalagorn
Copy link
Contributor

Summary

Bugfixes "Fix complition error on GCC"

Purpose of change

Fix game not compling on GCC after #77002 got merged

Describe the solution

It seems moving break; out of the ifs is the solution, thanks for Renech on Discord for suggesting

Describe alternatives you've considered

None.

Testing

Wanted to test locally, but I have trouble pulling from GitHub for the last hour or so, so making a PR so hopefully GitHub actions will have to do.

Additional context

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 13, 2024
@Faalagorn
Copy link
Contributor Author

Was able to compile locally, didn't test the debug crashing, but the game seems to compile and start fine with this fix applied

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 14, 2024
@Maleclypse Maleclypse merged commit 32eb1d6 into CleverRaven:master Oct 14, 2024
26 of 28 checks passed
@Faalagorn Faalagorn deleted the patch-1 branch October 14, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants