Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mutations able to use mana as resourse without EoC #77013

Merged
merged 12 commits into from
Oct 18, 2024

Conversation

Naadn
Copy link
Contributor

@Naadn Naadn commented Oct 13, 2024

Summary

Infrastructure "Make mutation able to use mana as resourse without EoC"

Purpose of change

I want to make a mutation for magiclysm that need mana to upkeep but I am too lazy to make a chunk of EoC just for it. Plus I keep thinking mutation can burn kcal, thirst and sleepiness but no mana. So I hope this change will make mods authors' life a tiny bit easier.

Describe the solution

Add some necessary codes to make mutation burning mana without EoC possable, update the doc and add a debug mana burning mutation to test.

Describe alternatives you've considered

Make a chunk of EoC just for my wip stuff.

Testing

Open a game with magiclysm mod so character has mana, debug the mana burning mutation to the test character.
After turned on the mutation it comsume mana as intended, when there is no enough mana to burn it auto turned off.
Can't turned on when character has less than required mana, NPC burning mana won't comsume player's.

Additional context

My internet environment really can't download whole CDDA repo to do compiling, so the test is done by friends. So far he said there is no problem when testing

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Oct 13, 2024
@Naadn Naadn changed the title Make mutation able to use mana as resourse without EoC Make mutations able to use mana as resourse without EoC Oct 13, 2024
@github-actions github-actions bot added the Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style label Oct 13, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Oct 13, 2024
Naadn and others added 3 commits October 13, 2024 22:30
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 13, 2024
@Maleclypse Maleclypse merged commit ba026ac into CleverRaven:master Oct 18, 2024
28 checks passed
@Naadn Naadn deleted the mutation-mana-burner branch October 18, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Documentation> Design documents, internal info, guides and help. Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants