-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mutations able to use mana as resourse without EoC #77013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
Info / User Interface
Game - player communication, menus, etc.
[JSON]
Changes (can be) made in JSON
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
[C++]
Changes (can be) made in C++. Previously named `Code`
[Markdown]
Markdown issues and PRs
labels
Oct 13, 2024
Naadn
changed the title
Make mutation able to use mana as resourse without EoC
Make mutations able to use mana as resourse without EoC
Oct 13, 2024
github-actions
bot
added
the
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
label
Oct 13, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Oct 13, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
<Documentation>
Design documents, internal info, guides and help.
Info / User Interface
Game - player communication, menus, etc.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Make mutation able to use mana as resourse without EoC"
Purpose of change
I want to make a mutation for magiclysm that need mana to upkeep but I am too lazy to make a chunk of EoC just for it. Plus I keep thinking mutation can burn kcal, thirst and sleepiness but no mana. So I hope this change will make mods authors' life a tiny bit easier.
Describe the solution
Add some necessary codes to make mutation burning mana without EoC possable, update the doc and add a debug mana burning mutation to test.
Describe alternatives you've considered
Make a chunk of EoC just for my wip stuff.
Testing
Open a game with magiclysm mod so character has mana, debug the mana burning mutation to the test character.
After turned on the mutation it comsume mana as intended, when there is no enough mana to burn it auto turned off.
Can't turned on when character has less than required mana, NPC burning mana won't comsume player's.
Additional context
My internet environment really can't download whole CDDA repo to do compiling, so the test is done by friends. So far he said there is no problem when testing