Clean up _path_path() functions
#76982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrieger
force-pushed
the
fewer_strings_longer_paths
branch
from
e180c59 to
1acfecd
Compare
github-actions
bot
added
the
[C++]
|
Actually I can take care of them all. |
akrieger
force-pushed
the
fewer_strings_longer_paths
branch
from
1acfecd to
3abc604
Compare
akrieger
changed the title
PATH_INFO::world_base_save_path()_path_path() functions
|
I am maybe not handling resetting a world correctly |
github-actions
bot
added
Info / User Interface
akrieger
force-pushed
the
fewer_strings_longer_paths
branch
from
3abc604 to
16b832f
Compare
github-actions
bot
added
the
BasicBuildPassed
akrieger
force-pushed
the
fewer_strings_longer_paths
branch
from
16b832f to
4bf68fb
Compare
github-actions
bot
added
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Describe the solution
Replace string functions with path functions. Remove string functions. Rename path functions to shorter form previously occupied by string functions.
Describe alternatives you've considered
Testing
It compiles. I can write into the diary and it appears on disk in the right place. I die, and the game gets graveyarded correctly (or at least, the same as it was before. I think there's preexisting bugs). I can delete a world with active players inside and it deletes correctly.
Additional context