Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change option groups to sentence case #76973

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

Faalagorn
Copy link
Contributor

@Faalagorn Faalagorn commented Oct 11, 2024

Summary

Interface "Make the option groups sentence case"

Purpose of change

Unify names to be sentence case.

Describe the solution

Make strings sentence case

Describe alternatives you've considered

Interface "Make the header of Auto Notes Options title case" (original PR, changed following the comment)

Testing

None (string changes).

Additional context

All headers (compare Safe Mode Options) are title case, so this one should be too.
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 11, 2024
@Night-Pryanik
Copy link

Maybe we should go the other way and de-capitalize all headers? I mean, is there a reason for "options" to be written in upper case, anyway?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 12, 2024
@Faalagorn
Copy link
Contributor Author

Maybe we should go the other way and de-capitalize all headers? I mean, is there a reason for "options" to be written in upper case, anyway?

Sure, should I change this PR to that instead or open a new one? I already decapitalize them all in Polish translation, as title case in here is generally reserved for just places and titles of magazines, movies and such.

@Night-Pryanik
Copy link

You can change them in this PR.

@Faalagorn Faalagorn changed the title Capitalize header of "Auto Notes Options" Change option groups to sentence case Oct 12, 2024
@Faalagorn
Copy link
Contributor Author

You can change them in this PR.

It should be done now, also fixes from #76977 should be included, let me know if something else needs adjusting!

@Night-Pryanik Night-Pryanik merged commit 1fb836e into CleverRaven:master Oct 13, 2024
27 checks passed
@Faalagorn Faalagorn deleted the patch-1 branch October 13, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants