Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E to eat food and a to activate it, no mixes #76920

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

E to eat food and a to activate it, no mixes #76920

wants to merge 3 commits into from

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Oct 9, 2024 •
edited
Loading

Summary

Infrastructure "Disentangle eat and activate for food"

Purpose of change

Potential fix for #76414

Describe the solution

  • Eat only eats food and doesn't check for activation

  • Activate only activates and doesn't look for eating

  • Make ALCOHOL a flag and an use action

  • Add NO_AUTO_CONSUME flag to some alcoholic drink that didn't have it [UNRELATED CHANGE]

Describe alternatives you've considered

Testing

  • activate in progress food > it works
  • activate in progress drugs > it works
  • Eat juvenile sourdough > you eat it
  • activate juvenile sourdough > you activate it
  • Eat pet food to eat it
  • Activate pet food to tame a pet

Additional context

  • Breaks alcool in the current state
  • Breaks corn cob
  • Might break drugs?

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 9, 2024
@RenechCDDA
Copy link
Member

I like the approach, good luck on shaking out the cobwebs 👍

@Karol1223
Copy link
Contributor

I am assuming this also breaks poison?

@AudBobb
Copy link
Contributor

AudBobb commented Oct 10, 2024 •
edited
Loading

Not a comment on the actual content of the PR, but just want to point out that you misspelled disentangle so you don't get this published to the changelog with a typo in the title :)

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Code: Tests Measurement, self-control, statistics, balancing. [Markdown] Markdown issues and PRs labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fris0uman @RenechCDDA @Karol1223 @AudBobb