Remove dead code, move doc to .h

[Brambor]

Summary

Infrastructure "Remove dead code"

Purpose of change

Found dead code again.

Describe the solution

• Used git bisect run as described in Refactor: Remove unnecessary parameter avatar #76498 (comment) again with tst code:

  • lines=$( cat src/avatar_action.cpp | grep ramp_move | wc -l )
    
    if [ $lines -eq 2 ]; then
      exit 1
    fi

Describe alternatives you've considered

Testing

Compiles?

Additional context

Found dead code again. We should have a test to find the dead code.

• Split off from Refactor: Remove unnecessary parameter avatar and map #76617, which is postponed for now.

[Brambor]

It says it is "unmergable" despite the commits being on the latest master... restarting tests didn't help.

[Brambor]

Restarting tests, it had a random unrelated failure.

[Maleclypse]

I resolved conflicts so please double check my work

[Brambor]

I resolved conflicts so please double check my work

I rebased it instead, but I am sure your merge was fine since it showed no changes at all. I like the clean history the rebasing provides.

Apart from the docs change, since it is a dead code removal, it just needs to compile.