Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract blood analysis descriptions and end screen text #76676

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

Uwuewsky
Copy link
Contributor

Summary

I18N "Extract blood analysis descs and end screen text"

Purpose of change

Some strings are not available for translation.

Describe the solution

  1. Extract blood analysis (autodoc) descriptions from effects.
  2. Extract text from end-death screens. (not working yet, the game doesn't use translations)

Describe alternatives you've considered

Testing

#. ~ String from the end screen, used in ASCII-art, so be aware of the string length.
#: data/json/end_screen.json
msgid "In memory of: <u_name>"
msgstr ""

#. ~ Blood analysis description of effect type "Poisoned Wound"
#: data/json/effects.json
msgid "Necrotizing Venom"
msgstr ""

endscreen
Снимок экрана_2024-09-26_13-32-54

Additional context

@github-actions github-actions bot added Translation I18n [Python] Code made in Python astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 26, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Antiasthmatics
  • Anticholinergic Tropane Alkaloids
  • Anticonvulsants
  • Benzodiazepines
  • Clostridium tetani Infection
  • Draculin
  • Heightened levels of organosulfur compounds, mercury, and silver.
  • Hemolytic Parasites
  • Severe Progressive Anemic Autophagy
  • Strange proteins are ingesting radioactive particles and containing all emmissions.
  • Streptobacillus moniliformis Infection
  • Unknown Hemolytic Parasite
  • Unknown RNA virus is rewriting sampled blood cells.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 26, 2024
@Maleclypse
Copy link
Member

I see a check failure on the files changed tab and I'm not sure if you are saying in the summary that you are unable to get the end screen text for translation? Are you needing someone to assist on that or were you saying that prior to this PR the end screen's weren't pulled for translations?

@Uwuewsky
Copy link
Contributor Author

Oops, used the wrong linter. The check failure should be fixed now.

No, the text is extracted for translation, but this translation will not be shown. The code doesn't seem to use the translation functions, so the original English text from JSON is printed on the end screen. I was planning to open an issue later.

Cataclysm-DDA/src/game.cpp

Lines 2926 to 2930 in b4ca7ca

for( std::pair<std::pair<int, int>, std::string> info : added_info ) {
if( row == info.first.second ) {
parse_tags( info.second, u, u );
ImGui::SameLine( str_width_to_pixels( info.first.first ), 0 );
cataimgui::draw_colored_text( info.second );

@Maleclypse Maleclypse merged commit 98afcb7 into CleverRaven:master Sep 28, 2024
21 checks passed
@Uwuewsky Uwuewsky deleted the extract-blood-desc branch September 29, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants