-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract blood analysis descriptions and end screen text #76676
Conversation
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
I see a check failure on the files changed tab and I'm not sure if you are saying in the summary that you are unable to get the end screen text for translation? Are you needing someone to assist on that or were you saying that prior to this PR the end screen's weren't pulled for translations? |
b1e0c04
to
06b53b9
Compare
Oops, used the wrong linter. The check failure should be fixed now. No, the text is extracted for translation, but this translation will not be shown. The code doesn't seem to use the translation functions, so the original English text from JSON is printed on the end screen. I was planning to open an issue later. Lines 2926 to 2930 in b4ca7ca
|
Summary
I18N "Extract blood analysis descs and end screen text"
Purpose of change
Some strings are not available for translation.
Describe the solution
Describe alternatives you've considered
Testing
Additional context