Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Xedra Evolved ] More gossamer clothing #76315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

I saw that Storm needs gossamer clothing recipes and realized I should pr this that I got partially done and see if it's helpful to him.

Describe the solution

Adds more gossamer clothing and recipes.

Describe alternatives you've considered

Waiting, watching, listening.

Testing

tbd god I have so many open PRs right now

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Armor / Clothing Armor and clothing Mods: Xedra Evolved Anything to do with Xedra Evolved labels Sep 9, 2024
@Maleclypse
Copy link
Member Author

@Standing-Storm if you want to steal any of this let me know and I'll delete anything that you are doing and if not I'll try and work on it

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A a tailed dueling jacket, it is multilayered so that it remains close to the skin for ease of movement, but has vents, tufts and flourishes that hide the true silhoute of the wearer. Part formal wear, part combat gear, it seems to be the kind of jacket worn by hotheaded youths looking for trouble in more civilized times.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 9, 2024
@Standing-Storm
Copy link
Contributor

@Standing-Storm if you want to steal any of this let me know and I'll delete anything that you are doing and if not I'll try and work on it

I think my changeling PR is going to be long enough without any recipes (letting Brownies make moon’s tears and glimmer fur clothes will have to wait), so go wild.

@Night-Pryanik
Copy link
Contributor

Can't restart the tests for some reason. @Maleclypse maybe you add or remove something to trigger the build?

@NetSysFire
Copy link
Member

I can't re-run these either. I think the reason for that is that the build failed 2 months ago. However: closing and re-opening the PR may do the trick here.

@NetSysFire NetSysFire closed this Nov 18, 2024
@NetSysFire NetSysFire reopened this Nov 18, 2024
@Night-Pryanik
Copy link
Contributor

closing and re-opening the PR may do the trick here

Good to know.

@NetSysFire
Copy link
Member

Since the test is still failing, I think this PR needs to be rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants