-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yrax protocols part1 #76291
Yrax protocols part1 #76291
Conversation
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
…iy/Cataclysm-DDA into Yrax-protocols-part1
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…iy/Cataclysm-DDA into Yrax-protocols-part1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding more deactivation manuals feels like a copout. I think you should just make it impossible for the player to disable the Yrax bots other than the Trifacet.
You can keep the option to deliver inactive drones to the Hub, but the player has to find them in inactive forms. You can add more dormant Yrax that work similar to the Sphenocoronae in future PRs.
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json
Outdated
Show resolved
Hide resolved
Co-authored-by: John Candlebury <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…iy/Cataclysm-DDA into Yrax-protocols-part1
I did't want for it to feel like copout, I wanted something like this to begin with. |
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…iy/Cataclysm-DDA into Yrax-protocols-part1
@Vgoloshivskiy please add migration for new manual id and at https://github.com/Vgoloshivskiy/Cataclysm-DDA/blob/bf05b72514cbee078b6a37c86791c585c5795549/data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json#L291 should be "TALK_ROBOFAC_INTERCOM_SELL_BROKEN_YRAX_DELTA" |
Summary
Content "Slightly Expands Hub-01 and Yrax factions"
Purpose of change
Yrax don't have a whole lot of content associated with them. I added a bit, plan on adding more content
Describe the solution
It adds to Yrax something more than just optional fight
Describe alternatives you've considered
I have no motivation to rewrite entire conversation "("
Testing
Worked without crashes but Hub reacted to robots only if i was holding them in inventory idk is it fixable or not
Additional context
Next part i will try myself at map editing and creating Gold Pyramid that reacts to electricity (being shot by laser / chain lightning from zed or emp grenade) or maybe being connected to generator