Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEBUG] Modify hordes through overmap editor #76269

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

RenechCDDA
Copy link
Member

@RenechCDDA RenechCDDA commented Sep 7, 2024

Summary

Infrastructure "[DEBUG] Modify hordes through overmap editor"

Purpose of change

I need to be able to modify hordes' values to debug them, and to test some possible upcoming content.

Describe the solution

Hook it into the existing overmap editor, and then write a bunch of new code to handle all the horde stuff

Also changed the overmap UI to always enable debug editor functions if debug mode is enabled, for ease of use. You can still access the overmap editor through the debug menu, but you don't have to.

Describe alternatives you've considered

Testing

2024-09-07.15-23-13.mp4

Additional context

PR as originally submitted is not finished. Notably the ability to modify monsters into existing hordes is just plain not implemented. Draft until it's done.
(It is done!)

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Set behavior to which enum value? Currently %d. \nAccepted values:\n0 = none,\n1 = city,\n2=roam,\n3=nemesis
  • Set horde's boolean values

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 7, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Sep 7, 2024
@RenechCDDA RenechCDDA marked this pull request as ready for review September 10, 2024 13:02
@RenechCDDA
Copy link
Member Author

@Qrox Auto notify failed to notify you. Here is your notification for something you are marked code owner for

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 10, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 15, 2024
@Maleclypse Maleclypse merged commit 72a5b8a into CleverRaven:master Sep 18, 2024
26 of 27 checks passed
@RenechCDDA RenechCDDA deleted the debug_menu_hordes branch September 18, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants