Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More NO_UNLOAD fixes #76263

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

bathtubs could take liquids out of NO_UNLOAD containers

Describe the solution

Actually check to see if the item is legal to unload

Describe alternatives you've considered

Refactoring iexamine::keg completely... it's kind of crusty

Testing

had some clean water (bottled), sports drink(sealed can), and liquid ammonia(in a NO_UNLOAD pressure tank), examined a bathtub

Could put clean water or sports drink in, putting in the sports drink correctly unsealed the container

Under no circumstances did it let me take the ammonia out of the pressure tank

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 7, 2024
@Maleclypse Maleclypse merged commit a7eca82 into CleverRaven:master Sep 8, 2024
26 of 28 checks passed
@RenechCDDA RenechCDDA deleted the bathtub_unload branch September 8, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants