Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulp acid-filled corpses #76262

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

SurFlurer
Copy link
Contributor

Summary

Bugfixes "Fix pulp acid-filled corpses"

Purpose of change

Fix #76236

Describe the solution

It was an oversight when migrating ACT_PULP. pulp_acid should be the indicator of whether the character has made their mind to pulp acid-filled corpses. If pulp_acid is true, the character will always pulp acid-filled corpses.

In the original implementation, only auto-pulping will use this value ( in fact, its equivalent ) to actually check acid immunity when dealing with acid-filled corpses. I added this ability to NPCs to avoid them being burned by pulping acid zombies.

Describe alternatives you've considered

Testing

  1. Wear regular outfit, pulp an acid corpse: the player gets a prompt as comfirmation, then the corpse gets pulped.
  2. Wear hub01 env suit, pulp an acid corpse: no prompt, and the corpse gets pulped.
  3. NPC with regular outfit, around a non-acid corpse: the corpse gets pulped.
  4. NPC with regular outfit, around an acid corpse: the corpse doesn't get pulped.
  5. NPC with hub01 env suit, around an acid corpse: the corpse gets pulped.
  6. Auto-pulp on, wear regular outfit, walk around an acid corpse: the corpse doesn't get pulped.
  7. Auto-pulp on, wear hub01 env suit, walk around an acid corpse: the corpse gets pulped.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 7, 2024
@Maleclypse Maleclypse merged commit 190eb0e into CleverRaven:master Sep 8, 2024
24 of 28 checks passed
@SurFlurer SurFlurer deleted the fix-pulp branch September 8, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't pulp acid-filled corpses
2 participants