Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix point hash to be well distributed. #76250

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Fix point hash to be well distributed. #76250

merged 1 commit into from
Sep 8, 2024

Conversation

akrieger
Copy link
Member

@akrieger akrieger commented Sep 6, 2024

Summary

Performance "Backport better point hash function for has_potential_los perf improvements"

Purpose of change

Backport of #76153 which is enough to fix the hash performance which made los cache checks slow.

Describe the solution

Backport it.

Describe alternatives you've considered

Also including the misc changes to map which DRY'd the cache key creation and other bits that conflicted with a straight graft.

Testing

See #76153

Additional context

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Performance Performance boosting code (CPU, memory, etc.) Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 6, 2024
@Maleclypse Maleclypse merged commit c6ba9a2 into CleverRaven:0.H-branch Sep 8, 2024
24 checks passed
@akrieger akrieger deleted the backport_76153 branch September 8, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Performance Performance boosting code (CPU, memory, etc.) <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akrieger @Maleclypse