Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Move bulk of spellcasting proficiency processing to dedicated EoCs and out of spell JSON (Kelvinist/Magus edition) #76242

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Sep 6, 2024

Summary

Mods "[Magiclysm] Move bulk of spellcasting proficiency processing to dedicated EoCs and out of spell JSON (Kelvinist/Magus edition)"

Purpose of change

Continuing moving JSON complexity to EoCs

Describe the solution

Update spells to move proficiency out of JSON to EoCs, for Kelvinists and Magi.

Describe alternatives you've considered

Testing

Loaded game up, paged through some spells, checked descriptions.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft September 6, 2024 16:36
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Sep 6, 2024
@github-actions github-actions bot requested a review from KorGgenT September 6, 2024 16:36
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 6, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 6, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review September 8, 2024 01:21
@Maleclypse Maleclypse merged commit 1fe4256 into CleverRaven:master Sep 9, 2024
23 of 34 checks passed
@Standing-Storm Standing-Storm deleted the kelvinist-magus-proficiencies branch September 10, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants