change the loading screen to a png file instead of avif #76226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the SDL_image library that comes with Fedora is compiled with support for AVIF images, but the SDL_image library that Windows users download is not. I should have noticed that AVIF support was optional, and opted not to use it in the first place. The image I used was originally an AVIF; at the time it seemed best to use it as–is. Instead of forcing Windows users to rebuild their dependencies with different build options, I’ll just bloat the releases by an extra 40kb. I doubt anyone will even notice. Fixes CleverRaven#76223
db48x
force-pushed
the
fix-image-format
branch
from
3088d81 to
c949b58
Compare
github-actions
bot
added
<Bugfix>
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Replace the loading screen image with a PNG"
Purpose of change
Fixes #76223
Testing
Start or load a game.
Additional context
Apparently the SDL_image library that comes with Fedora is compiled with support for AVIF images, but the SDL_image library that Windows users download is not. I should have noticed that AVIF support was optional, and opted not to use it in the first place. The image I used was originally an AVIF; at the time it seemed best to use it as–is.
Instead of forcing Windows users to rebuild their dependencies with different build options, I’ll just bloat the releases by an extra 40kb. I doubt anyone will even notice.