Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hear No Evil, Speak No Evil #76199

Merged
merged 19 commits into from
Sep 10, 2024
Merged

Conversation

DukePaulAtreid3s
Copy link
Contributor

@DukePaulAtreid3s DukePaulAtreid3s commented Sep 4, 2024

Summary

Content "Adds the AudioVox CBM as well as the WearMan CBM, the first transforming CBM."

Purpose of change

In #76177, Kevin removed the music action from the Integrated AR System CBM, which never should have had it in the first place. That did, however, open up a niche for a CBM that could actually play music. Originally, I was going to add radio cat ears, but then I looked to Cyberpunk for inspiration, and came across the CBMs that are being implemented here.

Describe the solution

The AudioVox is essentially a vocal synthesizer. It makes your voice louder; very, very much louder. The WearMan functions as a combination MP3 Player and Radio, allowing you to effectively listen to broadcasts without lugging one around. It transforms like the HUB Scout Headgear to facilitate this.

Describe alternatives you've considered

Cat Ear CBM

Testing

Screenshot 2024-09-04 153134
Screenshot 2024-09-04 153017
Screenshot 2024-09-04 153000

Additional context

Thank you GuardianDLL for letting me bounce ideas off of you, as well as your contributions to the community! This should also help with #73889

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions labels Sep 4, 2024
DukePaulAtreid3s and others added 3 commits September 4, 2024 15:54
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 4, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 5, 2024
@GuardianDll
Copy link
Member

few things: i think it would be better to use upgraded_bionic, included_bionics and available_upgrades with infolink, so infolink (gives radio) would be given automatically with this mp3 thingy
also speaking in vocoded should not give you any major advantage (nor disadvantage) in talks. social_modifiers should be removed

@DukePaulAtreid3s
Copy link
Contributor Author

DukePaulAtreid3s commented Sep 5, 2024

also speaking in vocoded should not give you any major advantage (nor disadvantage) in talks. social_modifiers should be removed

The Vocoded part is merely a part of it, the social effect comes from the ability completely and effortlessly change the natural sound of your voice, which means your voice can be perfectly harmonious and angelic, booming and growling, or even and inscrutable, all on a whim.

@worm-girl
Copy link
Contributor

worm-girl commented Sep 5, 2024

I agree with GuardianDLL about the vocoder. CBM tech is scary and ugly and not good for finessing terrified survivors. There's also already a CBM that gives you a robot voice, so it's redundant anyway.

@DukePaulAtreid3s
Copy link
Contributor Author

DukePaulAtreid3s commented Sep 5, 2024

I agree with GuardianDLL about the vocoder. CBM tech is scary and ugly and not good for finessing terrified survivors. There's also already a CBM that gives you a robot voice, so it's redundant anyway.

To be clear, social buffs are outside of CBMs intended spheres?

@DukePaulAtreid3s
Copy link
Contributor Author

few things: i think it would be better to use upgraded_bionic, included_bionics and available_upgrades with infolink, so infolink (gives radio) would be given automatically with this mp3 thingy also speaking in vocoded should not give you any major advantage (nor disadvantage) in talks. social_modifiers should be removed

Done!

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 5, 2024
@DukePaulAtreid3s
Copy link
Contributor Author

Basic build “passed” but the test crapped itself, redo

@GuardianDll
Copy link
Member

(continued from above) ERROR : src/bionics.cpp:539 [static void bionic_data::check_bionic_consistency()] Bionic bio_radio (included by bio_mp3) consumes slots, those should be part of the containing bionic instead.

@ashGlaw
Copy link
Contributor

ashGlaw commented Sep 6, 2024

Is the music played by this CBM audible by others, or is it silent?

@DukePaulAtreid3s
Copy link
Contributor Author

Is the music played by this CBM audible by others, or is it silent?

Silent, just like an MP3 player, the radio is also silent

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Sep 6, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A set of speakers implanted into the skull, able to pick up local radiowaves and play downloaded music.
  • A set of speakers implanted into your skull, that can recieve local radiowaves and play downloaded music at a concert hall quality. It comes with "Rubik's Mickse" preloaded. Activate it to start playing some tunes.
  • A set of speakers implanted into your skull, that can recieve local radiowaves and play downloaded music at a concert hall quality. It is currently playing "Rubik's Mickse". Activate it to find the Spirit of the Radio.
  • A set of speakers implanted into your skull, that can recieve local radiowaves and play downloaded music at a concert hall quality. It is currently playing "Rubik's Mickse". Activate it to turn it off.
  • An implanted set of vocal cords and speakers allowing the user to remodulate and project their voice at will.
  • AudioVox
  • AudioVox CBM
  • AudioVox CBMs
  • Hailing from a world choked with neon smog, and appreciated by Exodii artists, the AudioVox implant allows you to change, remodulate, and even autotune your voice. It also causes vocalizations /(such as shouts and singing/) to be much louder. It consists of an electronic voice box, synthetic larynx and multiple speakers implanted throughout your throat.
  • Surgically implanted into your skull near the eardrums are two speakers, as well as a small port behind the left earlobe. They can pick up local radio waves and play downloaded music in concert hall quality. It came pre-installed with "Rubik's Mickse".
  • WearMan
  • WearMan CBM
  • WearMan CBMs
  • WearMans
  • You switch your WearMan to the radio.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 7, 2024
@Maleclypse
Copy link
Member

I think this makes sense. It's obviously a commercial item that Exodii have scavenged and never bothered to change the user manual on. Fantastic :)

@Maleclypse Maleclypse merged commit 240cfd2 into CleverRaven:master Sep 10, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants