Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print church/school bell ringing sound in the message log once again #76146

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Interface "Print church/school bells ringing sound in the message log once again"

Purpose of change

#27227 and #32995 restricted some sounds from printing their descriptions in the message log. More precisely, only sounds from electronic speech and alarm categories will print their descriptions if they're originating from player position. Descriptions for all other sounds (if they're originating from player position) won't be printed. Church/school bells ringing is implemented as originating from player position, so it doesn't print its description.

Describe the solution

Changed sound type for church/school bells from music to alarm.

Describe alternatives you've considered

Change source of source for bells from player position to somewhere else. Don't know what solution is "proper".

Testing

Found church, activated its computer, made the bells ring. Checked that Bohm… Bohm… Bohm… sound is printed in message log.

Additional context

None.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 2, 2024
@Maleclypse Maleclypse merged commit 6dc152c into CleverRaven:master Sep 2, 2024
24 of 28 checks passed
@Night-Pryanik Night-Pryanik deleted the bells branch September 3, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants