Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GitHub errors; save overmap_fast_travel & overmap_fast_scroll #76145

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

Brambor
Copy link
Contributor

@Brambor Brambor commented Sep 2, 2024

Summary

None

Purpose of change

overmap_fast_travel & overmap_fast_scroll should save now. (TODO: check)

Fix some Github Errors:

Images of errors

image

image

image

The errors/warnings can be seen here (for example):

Describe the solution

Also removed the comment. It didn't seem helpful. Otherwise, the line would have to split for Astyle.

Describe alternatives you've considered

Testing

  1. Compiled locally.
  2. Let GitHub finish tests. GitHub doesn't report the test failures in this PR.
  3. Check overmap_fast_travel & overmap_fast_scroll should save now.
    1. Load a save.
    2. Open map.
    3. See that fast scroll is off.
    4. Toggle it.
    5. Save game.
    6. Restart CDDA.
    7. Load a save.
    8. Open map.
    9. See that fast scroll is on (in new version) off (in old version).

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` labels Sep 2, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 2, 2024
@Brambor
Copy link
Contributor Author

Brambor commented Sep 2, 2024

I tested that the values save. Good to go!

@Brambor Brambor changed the title fix GitHub errors: unused & 'point' from named constant fix GitHub errors; save overmap_fast_travel & overmap_fast_scroll Sep 2, 2024
@Brambor
Copy link
Contributor Author

Brambor commented Sep 2, 2024

Oh, the failing test is required, restarting then...

@Brambor Brambor closed this Sep 2, 2024
@Brambor Brambor reopened this Sep 2, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 3, 2024
@Maleclypse Maleclypse merged commit 8de672e into CleverRaven:master Sep 4, 2024
46 of 57 checks passed
@Brambor Brambor deleted the fix-unused branch September 4, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants