Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Address one aspect of #74232 (frequent crafting abortion). I don't think it's the only cause, though.
Describe the solution
Describe alternatives you've considered
Try to figure out which of the PICKUP_RANGE -1 radii are correct and which should be changed to the radius itself.
I've done the obvious one, leaving the ones that need evaluation for someone else.
Testing
With the first change only the error message gotten when crafting was started and then immediately aborted changed from the original without any code change.
With the second change the crafting proceeded.
Additional context
Including these two locations, there are others where PICKUP_RANGE - 1 are used:
activity_item_handling.cpp operation are_requirements_nearby in a !found_welder section. Should it be changed?
activity_item_handling.cpp operation can_do_activity_there in the ACT_VEHICLE_REPAIR section. Should it be changed?
activity_item_handling.cpp operation can_do_activity_there in the ACT_MULTIPLE_CRAFT section (the second one I changed)
activity_item_handling.cpp operation can_do_activity_there in hte ACT_MULTIPLE_DIS section. Should definitely be changed together with the previous entry.
activity_item_handling.cpp operation requirements_map. Should it be changed?
activity_item_handling.cpp operation generic_multi_activity_check_requirement (the one @MikasaTanikawa references in a post in the bug report). Should definitely be changed.
activity_item_handling.cpp operation generic_multiactivity_check_requirement. A bit further down. Should it be changed?