Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets in dialogs, part 1/3 #76135

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Conversation

Uwuewsky
Copy link
Contributor

@Uwuewsky Uwuewsky commented Sep 2, 2024

Summary

None

Purpose of change

#76102 broken into parts.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Missions Quests and missions astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 2, 2024
@GuardianDll
Copy link
Member

Restarting borked tests

@GuardianDll GuardianDll closed this Sep 4, 2024
@GuardianDll GuardianDll reopened this Sep 4, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 4, 2024
@worm-girl
Copy link
Contributor

worm-girl commented Sep 5, 2024

I don't think it's good to force a roleplaying "voice" on the player, especially a randomized one. Dialog responses should be short enough to understand at a glance, consistent, and not carry a tone that implies characterization, as some people are playing drooling mutant cannibals and some are playing kind hearted cyborgs.

This also presents issues where a player may not understand what a dialog option is supposed to mean because it changes every time they look at it.

@Maleclypse
Copy link
Member

So on review I think this is good and makes sense.

@Maleclypse Maleclypse merged commit 5399ceb into CleverRaven:master Oct 15, 2024
32 of 36 checks passed
@Uwuewsky Uwuewsky deleted the talk-snip-1 branch October 15, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants