properly compute colors for palette indexes above 15 in curses builds #76124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "avoid UB by properly computing colors for palette indexes above 15 in curses builds"
Purpose of change
Fixes #72973, #76092
Describe the solution
ANSI defines the default RGB values for color indexes above 15 using a simple formula, so just do that. While I was there, I went ahead and cached all the values avoid having to do division every time a color is needed from the palette. Probably not a huge cost savings overall, but it feels better.
Testing
Display any
uilist
with a disabled item in a curses build. Easiest way to do this is use “Play Now!” to start a new game, then walk into the same tile as the NPC who is with you in the evac shelter.