Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roof innawood caves #76109

Merged
merged 1 commit into from
Sep 1, 2024
Merged

roof innawood caves #76109

merged 1 commit into from
Sep 1, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Fix #76095, i.e. Innawood caves lacking roofs.

Describe the solution

Update the Innawood caves according to the same principles applied to vanilla caves.

Describe alternatives you've considered

Testing

  • Created an Innawood world and random character.
  • Debug spawned 9 innawood caves.
  • Teleported to them and examined them.
    Screenshot (627)
    Screenshot (628)
    This is not the full set of caves, but the same processing was performed on all of them. That, in combination with there not being any errors reported on load should provide a good confidence the changes work.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Innawood 🌲 Anything to do with Innawood mod <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 1, 2024
@dseguin dseguin merged commit 7f37775 into CleverRaven:master Sep 1, 2024
20 of 25 checks passed
@PatrikLundell PatrikLundell deleted the innawood branch September 1, 2024 12:07
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Innawoods Caves have no real roof.
2 participants