Remove generic bird egg, replace its role with chicken egg #76090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Our generic wild bird egg has actually been unused for anything but a glorified template for a while now. All values it had were based off chicken eggs anyway, so we can just cut out the middleman and use the chicken egg as the template (which, in vanilla, we already were doing)
Describe the solution
As the item was not actually present ingame anywhere save for the crafting UI, this gives no gameplay changes without mods
With mods, however, MoM players will now have a properly updated bird egg requirement group. The JSON comment was lying - it is perfectly possible to extend requirement groups without errors - as I did, and double tested to be sure
Describe alternatives you've considered
Testing
Additional context
No item migration because the item wasn't available outside debug anyway. If people more important than me wish for me to handle the migration regardless of this, I will.
This is going to require tileset files to be renamed after its merged.