Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add damage spellcasting_adjustment #76064

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Aug 30, 2024

Summary

None

Purpose of change

Storm told they'll redo the magiclysm proficiencies using spellcasting_adjustment if i'll make it alter damage
And man, i hate the way magiclysm proficiencies works

Describe the solution

Make spellcasting_adjustment accept argument damage

Testing

  {
    "type": "effect_on_condition",
    "id": "EOC_AAAAAA",
    "eoc_type": "EVENT",
    "required_event": "opens_spellbook",
    "effect": [ { "math": [ "u_spellcasting_adjustment('damage')", "=", "10" ] } ]
  },

image
image

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Aug 30, 2024
@github-actions github-actions bot requested a review from KorGgenT August 30, 2024 20:06
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 30, 2024
@Standing-Storm
Copy link
Contributor

Standing-Storm commented Aug 31, 2024

This is going to lead to a LOT of red lines in Magiclysm PRs.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 31, 2024
@dseguin dseguin merged commit 64437b7 into CleverRaven:master Sep 1, 2024
29 of 30 checks passed
@GuardianDll GuardianDll deleted the spellcast_adj_damage branch September 1, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants