Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Extend hedge magic research system, part 2 #76061

Merged

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[Xedra Evolved] Extend hedge magic research system, part 2"

Purpose of change

Finish up existing hedge magic texts onto the research system

Describe the solution

Move final four books over.

Describe alternatives you've considered

Testing

Books can be studied and teach rituals after they are.

Additional context

It'd be nice if studying were more engaging but reading badly-translated books written by weirdos and trying to draw occult knowledge out of them is probably extremely frustrating, to be honest.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Aug 30, 2024
@github-actions github-actions bot requested a review from Maleclypse August 30, 2024 18:11
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Aug 30, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • The Real Actual Spell Book of Bloodstoppers and Bearwalkers
  • The Real Actual Spell Goody Osborne's Booke of Remedies
  • The Real Actual Spell Malleus Maleficarum

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 30, 2024
@Maleclypse Maleclypse merged commit 50bdc55 into CleverRaven:master Sep 5, 2024
23 of 26 checks passed
@Standing-Storm Standing-Storm deleted the finish-hedge-magic-research branch September 5, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants