Extend/delete support for harvest lists #76047
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Extend/delete support for harvest lists"
Purpose of change
Fixes #75958
Fixes #61525
Describe the solution
Add and use
harvest_entry_reader
. Readers apparently can't handle std::list containers, so I changed theharvest_list::entries_
member to std::vector.Since the equality check for harvest entries only checks the
drop
member, giving that should be enough fordelete
.Also changed the
rabbit_with_skull
harvest to copy-from mammal_small_fur and extend with the skull to test functionality.Describe alternatives you've considered
Testing
Butchered a rabbit to check results.
Additional context
Result of full butchery of mon_rabbit