Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial chitinous helmets #76044

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

bloodbowel
Copy link
Contributor

@bloodbowel bloodbowel commented Aug 30, 2024

Summary

Features "Partial chitinous helmets"

Purpose of change

I like the idea of the chitinous armor, but the options working with it have been limited. It's lacking in some recipes. One thing I always wanted was the ability to create a chitinous helmet that isn't a "full helmet" that covers the mouth and eyes. Just a regular helmet.

Describe the solution

I created a chitinous helmet that leaves more of the front of the face open. This removes the mouth and eye encumbrance but still provides decent protection. Still covers the cheeks and chin. You can also slip a gas mask on while wearing this like a modern military style helmet. Now the original chitinous helmet is called a "full chitinous helmet" and this is just called a "chitinous helmet". Making it takes a little bit less material and time, but is about as difficult.

Describe alternatives you've considered

Maybe a chitinous helmet that can open and close. That way you get the best of both worlds. That might be a decent tailoring 8 recipe in addition to this. If some of the coverage isn't right tell me. I basically just took parts of the original helmet off. Also I don't know exactly how much less material this would take. I took 2 pieces of chitin off the base cost. Seemed reasonable to me.

Testing

Tested on my computer in debug mode in the tutorial room.

Additional context

Screenshot
Screenshot2

@github-actions github-actions bot added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 30, 2024
@CLIDragon
Copy link
Contributor

I don't think changing the id of the old chitin_helmet to chitin_helmet_full is a good idea. Anybody who loads an old save will find that their chitin helmet is now missing protection for the face. I don't think it can be migrated either, as (to the best of my knowledge) the migration system simply replaces ids on save load - it would be impossible to have a partial chitin helmet, as it would be replaced on save load.

Perhaps just give the new helmet the id chitin_helmet_partial. It should be ok to change the names.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 30, 2024
@Maleclypse
Copy link
Member

I don't think changing the id of the old chitin_helmet to chitin_helmet_full is a good idea. Anybody who loads an old save will find that their chitin helmet is now missing protection for the face. I don't think it can be migrated either, as (to the best of my knowledge) the migration system simply replaces ids on save load - it would be impossible to have a partial chitin helmet, as it would be replaced on save load.

Perhaps just give the new helmet the id chitin_helmet_partial. It should be ok to change the names.

This is the correct way to handle this due to the limits of migration mentioned above.

@bloodbowel
Copy link
Contributor Author

I didn't know you could even play old saves. I'll fix it.

@bloodbowel
Copy link
Contributor Author

I restored the original chitinous helmet which I called the "full chitinous helmet" back to being the standard chitinous helmet. Then I renamed the helmet I added with this pull request to be the "light chitinous helmet" instead.

So now you would have the regular helmet and this new light version. All the IDs should be correct.

@Maleclypse Maleclypse merged commit 2a454d5 into CleverRaven:master Sep 5, 2024
20 of 24 checks passed
@bloodbowel bloodbowel deleted the partial-chitinous-helmets branch September 6, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants