Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regular hearts to the game and make them obtainable through butchery #76041

Merged
merged 17 commits into from
Sep 3, 2024

Conversation

SariusSkelrets
Copy link
Contributor

@SariusSkelrets SariusSkelrets commented Aug 30, 2024

Summary

Content "Add regular hearts to the game and make them obtainable through butchery"

Purpose of change

For some reason, there is yet to be regular, non-jabberwocky hearts in game
I decided to add them

Describe the solution

  • Add the hearts food items
  • Add the snippets for mutant hearts
  • Add recipes using hearts
  • Add hearts to recipes using organ meat
  • Make the hearts be harvestable from humans, demihumans, mutants and non-insects animals

Describe alternatives you've considered

Let almost every living being be literally heartless

Testing

Game loads without errors, animals can be butchered and will drop chunks of heart
Butchering the others also drop hearts

heartfilled

Additional context

Not giving hearts to black dragons yet. They are dragons, so their hearts are expected to be special like the rest of their butcher products, but making special hearts is above the scope of this PR

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 30, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A chunk of heart from a mutated animal. Patches of hair and bits of bones are present all over and inside it, making it resemble a giant teratoma. Despite this, it appears to have functioned as a heart.
  • A chunk of heart from a mutated animal. This cancerous, gangrenous mass of flesh still beats, leaking out more of the foul fluids it used to push through a body. Beating isn't the only thing it continues to do, as you witness what kept this heart beating: the gangrene eating the cancer as the cancer grows back all over the gangrene, in a sickening ouroboros.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) and removed json-styled JSON lint passed, label assigned by github actions labels Aug 30, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 30, 2024
@SariusSkelrets SariusSkelrets marked this pull request as ready for review September 1, 2024 16:29
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Sep 1, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 1, 2024
Copy link
Contributor

@TheShadowFerret TheShadowFerret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harvestable eyeballs when 👀

data/json/items/comestibles/carnivore.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 2, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 2, 2024
@Maleclypse Maleclypse merged commit faea0f6 into CleverRaven:master Sep 3, 2024
17 of 24 checks passed
@SariusSkelrets SariusSkelrets deleted the Change_of_Heart branch September 3, 2024 12:52
@Naadn Naadn mentioned this pull request Sep 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants