Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npc butchering #76040

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix npc butchering #76040

merged 1 commit into from
Aug 30, 2024

Conversation

x-qq
Copy link

@x-qq x-qq commented Aug 30, 2024

Summary

Bugfixes "Fix NPC butchering requirements"

Purpose of change

Fixes #41814

Problem: NPCs consider any corpse over small size (46.25L) as large and require a nearby butchering rack and a table to process it.

Describe the solution

Solution: only require a rack for corpses size above creature_size::medium, and do not require a table as this requirement is neither communicated nor makes any sense.

Describe alternatives you've considered

Not doing this.

Testing

I've built this and tested it, ordering an NPC to butcher some medium and large corpses. It worked as expected.

Additional context

@github-actions github-actions bot added new contributor [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 30, 2024
@CLIDragon
Copy link
Contributor

I could be wrong but doesn't the player require a clean surface for butchering large corpses?

@RenechCDDA
Copy link
Member

can_do_activity_there and butcher_corpse_activity are not used by the player? This should be resolved if that is the case, but otherwise it seems you are also changing the player's ability to butcher.

@x-qq
Copy link
Author

x-qq commented Aug 30, 2024

can_do_activity_there and butcher_corpse_activity are not used by the player? This should be resolved if that is the case, but otherwise it seems you are also changing the player's ability to butcher.

The player's requirements are not changed. Here is what happens when a butchery of a large corpse (pig) is attempted by the player:

Untitled

I could be wrong but doesn't the player require a clean surface for butchering large corpses?

Does not look like it from the above screenshot.

@CLIDragon
Copy link
Contributor

Does not look like it from the above screenshot.

Must have been a memory from an older version then. In that case, I suspect that NPCs requiring a table was a holdover from the older version where players also required one.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 30, 2024
@Maleclypse Maleclypse merged commit b325a47 into CleverRaven:master Aug 30, 2024
28 checks passed
@Maleclypse
Copy link
Member

Compiled and tested against current build no change to PC butchering. Thanks for your contribution!

@x-qq x-qq deleted the fix-npc-butchering branch August 30, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPC's can't butcher bigger corpses even after having met the necessary conditions.
4 participants